From 31cc72f660513b033cc0621782586562bafab08e Mon Sep 17 00:00:00 2001
From: cbdev <cb@cbcdn.com>
Date: Tue, 10 Dec 2019 22:35:59 +0100
Subject: Fix bug in sACN config parsing

---
 TODO            | 12 +++---------
 backends/osc.c  |  1 +
 backends/sacn.c |  1 +
 installer_todo  |  1 -
 4 files changed, 5 insertions(+), 10 deletions(-)
 delete mode 100644 installer_todo

diff --git a/TODO b/TODO
index cba1c15..f6fc728 100644
--- a/TODO
+++ b/TODO
@@ -1,15 +1,9 @@
-winmidi
-rename
-release
-
-MIDI NRPN
 keepalive channels per backend?
 mm_backend_start might get some arguments so they don't have to fetch them all the time
-mm_channel_resolver might get additional info about the mapping direction
 Note source in channel value struct
 Optimize core channel search (store backend offset)
 
-mm_managed_fd.impl is not freed currently
+mm_managed_fd.impl is not freed currently (and is heaped most of the time anyway) -> documentation
+
+installer: implement an upgrade mode (check for newer versions in the repo)
 
-rtpmidi mode=peer
-	mode=initiator
diff --git a/backends/osc.c b/backends/osc.c
index 757ad89..b12ae40 100644
--- a/backends/osc.c
+++ b/backends/osc.c
@@ -522,6 +522,7 @@ static int osc_configure_instance(instance* inst, char* option, char* value){
 			return 1;
 		}
 
+		//this requests a socket with SO_BROADCAST set, whether this is useful functionality for OSC is up for debate
 		data->fd = mmbackend_socket(host, port, SOCK_DGRAM, 1, 1);
 		if(data->fd < 0){
 			fprintf(stderr, "Failed to bind for instance %s\n", inst->name);
diff --git a/backends/sacn.c b/backends/sacn.c
index edb648d..75c327e 100644
--- a/backends/sacn.c
+++ b/backends/sacn.c
@@ -171,6 +171,7 @@ static int sacn_configure_instance(instance* inst, char* option, char* value){
 	}
 	else if(!strcmp(option, "unicast")){
 		data->unicast_input = strtoul(value, NULL, 10);
+		return 0;
 	}
 
 	fprintf(stderr, "Unknown configuration option %s for sACN backend\n", option);
diff --git a/installer_todo b/installer_todo
deleted file mode 100644
index c9935ae..0000000
--- a/installer_todo
+++ /dev/null
@@ -1 +0,0 @@
--Updater (Remote Repo letzten tag lesen und mit lokaler installation abgleichen)
\ No newline at end of file
-- 
cgit v1.2.3