diff options
| author | cbdev <cb@cbcdn.com> | 2018-03-16 01:18:35 +0100 |
|---|---|---|
| committer | cbdev <cb@cbcdn.com> | 2018-03-16 01:18:35 +0100 |
| commit | eabc4d0e07d2fb2f2a9aaf2571af490ec7e55b7d (patch) | |
| tree | eb3ee0aa6178e10d2ddef38f2921fa63d09a1fd2 /backends/osc.c | |
| parent | 5df6379df17fd7875e54ef7c5b5d07c5edb95644 (diff) | |
| download | midimonster-eabc4d0e07d2fb2f2a9aaf2571af490ec7e55b7d.tar.gz midimonster-eabc4d0e07d2fb2f2a9aaf2571af490ec7e55b7d.tar.bz2 midimonster-eabc4d0e07d2fb2f2a9aaf2571af490ec7e55b7d.zip | |
Fix issues found by Coverity Scan
Diffstat (limited to 'backends/osc.c')
| -rw-r--r-- | backends/osc.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/backends/osc.c b/backends/osc.c index adc91f5..5f94ec2 100644 --- a/backends/osc.c +++ b/backends/osc.c @@ -334,6 +334,7 @@ static int osc_listener(char* host, char* port){ //set nonblocking flags = fcntl(fd, F_GETFL, 0); if(fcntl(fd, F_SETFL, flags | O_NONBLOCK) < 0){ + close(fd); fprintf(stderr, "Failed to set OSC descriptor nonblocking\n"); return -1; } @@ -697,7 +698,7 @@ static int backend_handle(size_t num, managed_fd* fds){ else{ bytes_read = recv(fds[fd].fd, recv_buf, sizeof(recv_buf), 0); } - if(data->root && strncmp(recv_buf, data->root, strlen(data->root))){ + if(data->root && strncmp(recv_buf, data->root, min(bytes_read, strlen(data->root)))){ //ignore packet for different root continue; } @@ -802,7 +803,9 @@ static int backend_shutdown(){ } free(data->channel); free(data->root); - close(data->fd); + if(data->fd >= 0){ + close(data->fd); + } data->fd = -1; data->channels = 0; free(inst[u]->impl); |